Fixed a bug concerning the scheduling of the idle thread

ergo720 · Aug 19, 2024 · ed40a1a · ed40a1a
1 parent cf28937
commit ed40a1a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/nboxkrnl/ke/thread.cpp b/nboxkrnl/ke/thread.cpp
@@ -250,11 +250,13 @@ static PKTHREAD XBOXAPI KiFindAndRemoveHighestPriorityThread(KPRIORITY LowPriori
 {
 	assert(KeGetCurrentIrql() == DISPATCH_LEVEL);
 
+	if (KiReadyThreadMask == 0) {
+		return nullptr;
+	}
+
 	KPRIORITY HighestPriority;
 	__asm {
 		bsr eax, KiReadyThreadMask
-		mov ecx, -1
-		cmovz eax, ecx
 		mov HighestPriority, eax
 	}
 

diff --git a/nboxkrnl/ki/ki.hpp b/nboxkrnl/ki/ki.hpp
@@ -134,7 +134,7 @@ inline uint8_t alignas(4) KiIdleThreadStack[KERNEL_STACK_SIZE];
 inline LIST_ENTRY KiReadyThreadLists[NUM_OF_THREAD_PRIORITIES];
 
 // Bitmask of KiReadyThreadLists -> bit position is one if there is at least one ready thread at that priority
-inline DWORD KiReadyThreadMask = 1;
+inline DWORD KiReadyThreadMask = 0;
 
 inline LIST_ENTRY KiWaitInListHead;