MetGrid GPU Fix #1888
Merged
MetGrid GPU Fix #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construction of the base state with MetGrid had a foundational issue when on the GPU. Specifically, the use of
DeviceVectorsto do column-wise operations will not work on the GPU since multiple threads will try to access that vector at the same time, causing a race condition. We now eliminate thecalc_rho_proutine and directly interact with theNewton_Raphsoniterator by integrating fromk = [1 kmax], where we need onlyk-1andkvalues.