Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the WPS regtest failure.
We have defined the following:
#define NDRY 4
#define NSCALARS 1
#define NMOIST_max 6
#define NBCVAR_max (NDRY + 1 + NMOIST_max)
But did not propagate that change to the BC vars (BCVars only goes up to
RhoQ2_bc_comp
). Therefore, we had uninitialized data when constructing the BC types. Recent changes to Dirichlet walls check if the bc value is not equal to the initial bc value to identify a Dirichlet condition with NoSlip or Slip walls. The uninitialized data caused this block of code to be true when it shouldn't have been. The correction in this PR is to simply initialize all of the BC components.