Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WPS regtest. #1828

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix WPS regtest. #1828

merged 1 commit into from
Sep 23, 2024

Conversation

AMLattanzi
Copy link
Collaborator

This PR corrects the WPS regtest failure.

We have defined the following:
#define NDRY 4
#define NSCALARS 1
#define NMOIST_max 6
#define NBCVAR_max (NDRY + 1 + NMOIST_max)

But did not propagate that change to the BC vars (BCVars only goes up to RhoQ2_bc_comp). Therefore, we had uninitialized data when constructing the BC types. Recent changes to Dirichlet walls check if the bc value is not equal to the initial bc value to identify a Dirichlet condition with NoSlip or Slip walls. The uninitialized data caused this block of code to be true when it shouldn't have been. The correction in this PR is to simply initialize all of the BC components.

@AMLattanzi AMLattanzi merged commit dd122aa into erf-model:development Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant