New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit override in moist qstate function #1384

Merged

baperry2 merged 1 commit into erf-model:development from baperry2:moist-qstate-override

Jan 17, 2024

Collaborator

baperry2 commented Jan 16, 2024

To avoid compiler warnings like:

../../../Source/Microphysics/Kessler/Kessler.H:134:5: warning: 'Qstate_Size' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
    Qstate_Size () { return Kessler::m_qstate_size; }
    ^
../../../Source/Microphysics/Null/NullMoist.H:59:5: note: overridden virtual function is here
    Qstate_Size () { return NullMoist::m_qstate_size; }


add explicit override in moist qstate function

68eaf5c

baperry2 requested a review from AMLattanzi

January 16, 2024 22:38

AMLattanzi approved these changes

View reviewed changes

Collaborator

AMLattanzi left a comment

Good catch. Thank you for fixing this.

baperry2 merged commit 1978dd2 into erf-model:development

11 checks passed

baperry2 deleted the moist-qstate-override branch

January 17, 2024 00:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment