fix outflow bc for boundary normal velocities. #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The face centered velocity located on an outflow boundary must be treated differently. The FOEXTRAP causes an erroneous update for normal velocity at the boundary; this sustains a very small boundary velocity that does not relax to the adjacent flow field inside the domain.
This PR modifies the outflow BC to utilize a second order Neumann condition to specify the boundary value. The source for the stencil is as follows:
Simulating in Exec/Regtests/Bubble with inputs_BF02_moist_bubble shows that the contours in xvelocity are no longer suppressed at the boundary or within the domain:
