-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for terrain / grid stretching #1361
Merged
asalmgren
merged 18 commits into
erf-model:development
from
ewquon:grid_stretching_updates
Jan 9, 2024
Merged
Updates for terrain / grid stretching #1361
asalmgren
merged 18 commits into
erf-model:development
from
ewquon:grid_stretching_updates
Jan 9, 2024
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 364ddfb - Browse repository at this point
Copy the full SHA 364ddfbView commit details -
Init zlevels_stag before amrex_probinit; warn if levels dont match pr…
…oblem domain It may make sense to update the problem domain if possible
Configuration menu - View commit details
-
Copy full SHA for 2913db4 - Browse repository at this point
Copy the full SHA 2913db4View commit details -
Set the correct ztop from zlevels_stag
init_terrain_grid() used to use ztop = geom.ProbHiArray()[2], which comes from the input file. For a stretched grid or user-specified "terrain_z_levels", there could have been a mismatch between ztop and the actual requested top of the domain.
Configuration menu - View commit details
-
Copy full SHA for f2208a9 - Browse repository at this point
Copy the full SHA f2208a9View commit details -
Implement default init_custom_terrain() consistent with flat terrain …
…defintions in most prob.cpps
Configuration menu - View commit details
-
Copy full SHA for fa4d13a - Browse repository at this point
Copy the full SHA fa4d13aView commit details -
Remove unnecessary override of init_custom_terrain
Note: The regression tests DynamicRefinement, IsentropicVortex, and ScalarAdvDiff all explicitly initialized z_phys_nd to be k*dz and then called FillBoundary(). However, if use_terrain==true (and init_custom_terrain() was called), then the default behavior should be equivalent: init_zlevels() called without grid stretching, then init_terrain_grid() called to populate z_phys_nd and then FillBoundary()
Configuration menu - View commit details
-
Copy full SHA for 578c1a9 - Browse repository at this point
Copy the full SHA 578c1a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96f9972 - Browse repository at this point
Copy the full SHA 96f9972View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6ae8c - Browse repository at this point
Copy the full SHA ed6ae8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cd95d2 - Browse repository at this point
Copy the full SHA 9cd95d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2ff9ce - Browse repository at this point
Copy the full SHA d2ff9ceView commit details
Commits on Jan 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e4c887e - Browse repository at this point
Copy the full SHA e4c887eView commit details -
Merge branch 'grid_stretching_updates' of github.com:ewquon/ERF into …
…grid_stretching_updates
Configuration menu - View commit details
-
Copy full SHA for d9e0d86 - Browse repository at this point
Copy the full SHA d9e0d86View commit details -
Configuration menu - View commit details
-
Copy full SHA for d58e61a - Browse repository at this point
Copy the full SHA d58e61aView commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ca8f8a - Browse repository at this point
Copy the full SHA 3ca8f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80fa331 - Browse repository at this point
Copy the full SHA 80fa331View commit details -
Configuration menu - View commit details
-
Copy full SHA for 343ebff - Browse repository at this point
Copy the full SHA 343ebffView commit details -
Implement terrain-aware input-sounding initialization
Notes: - Nominal z levels (e.g., from input terrain_z_levels) that are used for terrain smoothing should range from 0 (on the surface) to ztop - The same levels are used to calculate the base state by integrating the hydrostatic equation through a column of air - In the case of terrain or grid stretching, the base state profiles may have non-uniform vertical grid spacing - These 1-D profiles are then interpolated to the 3-D terrain grid; the state and hse fab arrays are interpolated at z_phys_cc whereas the velocity fab arrays are interpolated at face centers calculated from z_phys_nd
Configuration menu - View commit details
-
Copy full SHA for 302d57e - Browse repository at this point
Copy the full SHA 302d57eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8affdaf - Browse repository at this point
Copy the full SHA 8affdafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e59f71 - Browse repository at this point
Copy the full SHA 1e59f71View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.