Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for terrain / grid stretching #1361

Merged
merged 18 commits into from
Jan 9, 2024

Commits on Jan 4, 2024

  1. Configuration menu
    Copy the full SHA
    364ddfb View commit details
    Browse the repository at this point in the history
  2. Init zlevels_stag before amrex_probinit; warn if levels dont match pr…

    …oblem domain
    
    It may make sense to update the problem domain if possible
    ewquon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2913db4 View commit details
    Browse the repository at this point in the history
  3. Set the correct ztop from zlevels_stag

    init_terrain_grid() used to use ztop = geom.ProbHiArray()[2], which
    comes from the input file. For a stretched grid or user-specified
    "terrain_z_levels", there could have been a mismatch between ztop and
    the actual requested top of the domain.
    ewquon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    f2208a9 View commit details
    Browse the repository at this point in the history
  4. Implement default init_custom_terrain() consistent with flat terrain …

    …defintions in most prob.cpps
    ewquon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fa4d13a View commit details
    Browse the repository at this point in the history
  5. Remove unnecessary override of init_custom_terrain

    Note: The regression tests DynamicRefinement, IsentropicVortex, and
    ScalarAdvDiff all explicitly initialized z_phys_nd to be k*dz and then
    called FillBoundary(). However, if use_terrain==true (and
    init_custom_terrain() was called), then the default behavior should be
    equivalent: init_zlevels() called without grid stretching, then
    init_terrain_grid() called to populate z_phys_nd and then FillBoundary()
    ewquon committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    578c1a9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    96f9972 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ed6ae8c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9cd95d2 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d2ff9ce View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Cleanup

    ewquon committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    e4c887e View commit details
    Browse the repository at this point in the history
  2. Merge branch 'grid_stretching_updates' of github.com:ewquon/ERF into …

    …grid_stretching_updates
    ewquon committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    d9e0d86 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d58e61a View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    3ca8f8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    80fa331 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    343ebff View commit details
    Browse the repository at this point in the history
  4. Implement terrain-aware input-sounding initialization

    Notes:
    - Nominal z levels (e.g., from input terrain_z_levels) that are used for
      terrain smoothing should range from 0 (on the surface) to ztop
    - The same levels are used to calculate the base state by integrating
      the hydrostatic equation through a column of air
    - In the case of terrain or grid stretching, the base state profiles
      may have non-uniform vertical grid spacing
    - These 1-D profiles are then interpolated to the 3-D terrain grid; the
      state and hse fab arrays are interpolated at z_phys_cc whereas the
      velocity fab arrays are interpolated at face centers calculated from
      z_phys_nd
    ewquon committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    302d57e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8affdaf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1e59f71 View commit details
    Browse the repository at this point in the history