Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast eddy microphysics clean up #1336

Merged
merged 32 commits into from
Dec 11, 2023
Merged

Conversation

nataraj2
Copy link
Collaborator

This PR cleans up the FastEddy microphysics. The workflow for the FastEddy case is as follows

  1. prob.cpp initializes rhoQ1 and rhoQ2 - i.e. rhoqv and rhoqc.
  2. rhoQ1 and rhoQ2 are advected.
  3. Init_FE.cpp defines micvars qv and qc from rhoQ1 and rhoQ2 (dividing by rho)
  4. FastEddy.cpp updates qv, qc and theta - condensation and evaporation (no precipitation)
  5. Diagnose_FE.cpp is empty - we solve for qv and qc - nothing to be diagnosed.
  6. Update_FE.cpp updates rhoTheta, rhoQ1 (i.e. rhoqv) and rhoQ2 (i.e. rhoqc) using the updated values in step 4.

@asalmgren asalmgren merged commit f83644c into erf-model:development Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants