Fix index issues and plotfile index divide by rho.

erf-model · Dec 20, 2023 · d1b0edf · d1b0edf
1 parent d38cf68
commit d1b0edf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Source/IO/Plotfile.cpp b/Source/IO/Plotfile.cpp
@@ -222,7 +222,7 @@ ERF::WritePlotFile (int which, Vector<std::string> plot_var_names)
 
  ParallelFor(bx, [=] AMREX_GPU_DEVICE(int i, int j, int k) noexcept
  {
- Real qv_for_p = (use_moisture) ? S_arr(i,j,k,RhoQ1_comp) : 0;
+ Real qv_for_p = (use_moisture) ? S_arr(i,j,k,RhoQ1_comp)/S_arr(i,j,k,Rho_comp) : 0;
  const Real rhotheta = S_arr(i,j,k,RhoTheta_comp);
  derdat(i, j, k, mf_comp) = getPgivenRTh(rhotheta,qv_for_p);
  });
@@ -243,7 +243,7 @@ ERF::WritePlotFile (int which, Vector<std::string> plot_var_names)
 
  ParallelFor(bx, [=] AMREX_GPU_DEVICE(int i, int j, int k) noexcept
  {
- Real qv_for_p = (use_moisture) ? S_arr(i,j,k,RhoQ1_comp) : 0;
+ Real qv_for_p = (use_moisture) ? S_arr(i,j,k,RhoQ1_comp)/S_arr(i,j,k,Rho_comp) : 0;
  const Real rhotheta = S_arr(i,j,k,RhoTheta_comp);
  derdat(i, j, k, mf_comp) = getPgivenRTh(rhotheta,qv_for_p) - p0_arr(i,j,k);
  });

diff --git a/Source/TimeIntegration/ERF_make_buoyancy.cpp b/Source/TimeIntegration/ERF_make_buoyancy.cpp
@@ -161,7 +161,7 @@ void make_buoyancy (Vector<MultiFab>& S_data,
  amrex::ParallelFor(tbz, [=] AMREX_GPU_DEVICE (int i, int j, int k)
  {
  Real rhop_hi = cell_data(i,j,k ,Rho_comp) + cell_data(i,j,k ,RhoQ1_comp) + cell_data(i,j,k ,RhoQ2_comp) - r0_arr(i,j,k );
- Real rhop_lo = cell_data(i,j,k-1,Rho_comp) + cell_data(i,j,k-1,RhoQ2_comp) + cell_data(i,j,k-1,RhoQ2_comp) - r0_arr(i,j,k-1);
+ Real rhop_lo = cell_data(i,j,k-1,Rho_comp) + cell_data(i,j,k-1,RhoQ1_comp) + cell_data(i,j,k-1,RhoQ2_comp) - r0_arr(i,j,k-1);
  buoyancy_fab(i, j, k) = grav_gpu[2] * 0.5 * ( rhop_hi + rhop_lo );
  });
  } // mfi