Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all etcd client configs #322

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

chengjoey
Copy link
Contributor

What this PR does / why we need it:

support all etcd client configs

Specified Reviewers:

/assign @sfwn

@erda-bot erda-bot requested a review from sfwn July 30, 2024 08:06
sfwn
sfwn previously approved these changes Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 19.16%. Comparing base (f3a2492) to head (3562849).
Report is 3 commits behind head on master.

Files Patch % Lines
providers/etcd/etcd.go 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #322       +/-   ##
===========================================
- Coverage   35.54%   19.16%   -16.38%     
===========================================
  Files         110      309      +199     
  Lines        6055    13676     +7621     
===========================================
+ Hits         2152     2621      +469     
- Misses       3738    10825     +7087     
- Partials      165      230       +65     
Flag Coverage Δ
by-github-actions 19.16% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
providers/etcd/etcd.go 0.00% <0.00%> (ø)

... and 201 files with indirect coverage changes

@sfwn
Copy link
Member

sfwn commented Jul 31, 2024

/approve

@sfwn sfwn merged commit 4509125 into erda-project:master Jul 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants