Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/bookmark/align with existing code #2691

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Jan 9, 2025

Why

Update the bookmarks module to use the IBookmarkProvider interface, add an enableBookmark function for better application integration, and refactor related components for improved context handling. Minor fixes and adjustments were also made to enhance overall functionality.

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

@github-actions github-actions bot added 🐞 bug Something isn't working 👨🏻‍🍳 cookbooks 👾 React 💾 CLI fusion framework CLI 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request labels Jan 9, 2025
@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from aa75ea3 to 0df9d8f Compare January 9, 2025 11:23
@github-actions github-actions bot added 🚧 chore maintaines work, (update deps, workflos ...) 🧬 Modules labels Jan 9, 2025
@odinr odinr force-pushed the fix/bookmark/align-with-existing-code branch from 0df9d8f to 36ca730 Compare January 10, 2025 12:55
Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: 36ca730

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@equinor/fusion-framework-react-components-bookmark Patch
@equinor/fusion-framework-cli Minor
@equinor/fusion-framework-react-module-bookmark Minor
@equinor/fusion-framework-cookbook-app-react-bookmark Patch
@equinor/fusion-framework-module-bookmark Minor
@equinor/fusion-framework-react-app Minor
@equinor/fusion-framework-app Minor
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch
@equinor/fusion-framework-react-components-people-provider Patch
@equinor/fusion-framework-legacy-interopt Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 💾 CLI fusion framework CLI 👨🏻‍🍳 cookbooks 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request 🧬 Modules 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant