Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(module-ag-grid): upgrade to AG Grid 33 #2687

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Jan 8, 2025

Why

Enhanced the AG Grid module with new functionalities and improvements.

  • Added TypeScript type definitions for better type support.
  • Introduced new exports for community, enterprise, and themes.
  • Implemented AgGridConfigurator and AgGridProvider classes for better configuration and initialization.
  • Added support for setting and clearing themes, managing modules, and setting license keys.
  • Updated the module.ts to use the new configurator and provider classes.
  • Removed deprecated files and refactored the module structure for better maintainability.

Detailed Changes:

  • package.json: Updated dependencies and added new exports.
  • AgGridConfigurator.interface.ts: Defined the interface for configuring AG Grid settings and modules.
  • AgGridConfigurator.ts: Implemented the AgGridConfigurator class for managing AG Grid configuration.
  • AgGridProvider.ts: Implemented the AgGridProvider class for providing AG Grid configuration.
  • community.ts: Exported all from ag-grid-community.
  • default-modules.ts: Added a placeholder for default modules.
  • enterprise.ts: Exported all from ag-grid-enterprise.
  • index.ts: Updated exports to use the new configurator and provider.
  • module.ts: Refactored to use the new configurator and provider classes.
  • themes.ts: Added a default theme for AG Grid.

Breaking Changes:

  • @ag-grid-community/* and @ag-grid-enterprise/* must be removed from the project dependencies.
  • The new configurator no longer supports setting license keys directly. Use the setLicense function to set license keys.
  • Modules are now managed through the AgGridConfigurator class. Use the setModule or addModule function to set/add modules to the configuration.

References:

closes:

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: d8abbf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/fusion-framework-cookbook-app-react-ag-grid Patch
@equinor/fusion-framework-react-app Patch
@equinor/fusion-framework-module-ag-grid Major
@equinor/fusion-framework-legacy-interopt Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 👨🏻‍🍳 cookbooks 👾 React 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request 🧬 Modules labels Jan 8, 2025
@github-actions github-actions bot added the 🚧 chore maintaines work, (update deps, workflos ...) label Jan 8, 2025
@odinr odinr marked this pull request as ready for review January 8, 2025 13:14
@odinr odinr requested a review from a team as a code owner January 8, 2025 13:14
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.4% 1751 / 437126
🔵 Statements 0.4% 1751 / 437126
🔵 Functions 22.83% 206 / 902
🔵 Branches 36.78% 387 / 1052
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
cookbooks/app-react-ag-grid/src/App.tsx 0% 0% 0% 0% 1-91
cookbooks/app-react-ag-grid/src/config.ts 0% 0% 0% 0% 1-43
packages/modules/ag-grid/src/AgGridConfigurator.interface.ts 100% 100% 100% 100%
packages/modules/ag-grid/src/AgGridConfigurator.ts 0% 0% 0% 0% 1-56
packages/modules/ag-grid/src/AgGridProvider.ts 0% 0% 0% 0% 1-45
packages/modules/ag-grid/src/community.ts 0% 0% 0% 0% 1
packages/modules/ag-grid/src/default-modules.ts 0% 100% 100% 0% 3-5
packages/modules/ag-grid/src/enterprise.ts 0% 0% 0% 0% 1
packages/modules/ag-grid/src/index.ts 0% 0% 0% 0% 1-3
packages/modules/ag-grid/src/module.ts 0% 0% 0% 0% 1-51
packages/modules/ag-grid/src/themes.ts 0% 0% 0% 0% 1-9
packages/react/app/src/ag-grid/useTheme.ts 0% 0% 0% 0% 1-13
packages/react/app/src/bookmark/useBookmark.ts 0% 0% 0% 0% 1-26
packages/react/modules/bookmark/src/index.ts 0% 0% 0% 0% 1
Generated in workflow #8288 for commit d8abbf3 by the Vitest Coverage Report Action

AndrejNikolicEq
AndrejNikolicEq previously approved these changes Jan 8, 2025
eikeland
eikeland previously approved these changes Jan 9, 2025
@odinr
Copy link
Collaborator Author

odinr commented Jan 9, 2025

preview of @equinor/fusion-framework-module-ag-grid@ag-grid-v33 generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 chore maintaines work, (update deps, workflos ...) 👨🏻‍🍳 cookbooks 📚 documentation Improvements or additions to documentation 🚀 feature New feature or request ✨ improvement 🧬 Modules 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants