-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Stop adding parameters into the object metadata #847
Conversation
@@ -208,71 +209,28 @@ def uuid_from_string(string: str) -> uuid.UUID: | |||
def read_parameters_txt(pfile: Path | str) -> types.Parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This utility function is used by fmu-sumo-uploader.
Can the functionality be moved in there instead @perolavsvendsen ?
Also refactored to simplify the logic and removed the _design_kw
file copied from semeio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with me
I think this should be OK, but I recommend asking around a bit if anyone is actually depending on this before merging. I am pretty sure REP is not using it, but I don't know about Webviz and any other consumer. |
I have asked a bit around: |
b14b956
to
0239b95
Compare
0239b95
to
3341ae0
Compare
PR to stop adding parameters into every object metadata.
Parameters are uploaded via the
fmu-sumo-uploader
as one file per realization withcontent="parameters",
and is planned to be added to the newRealization
object #774 -> hence there is no longer a need to include it in the object metadataAdresses #345