Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Stop adding parameters into the object metadata #847

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Oct 14, 2024

PR to stop adding parameters into every object metadata.

Parameters are uploaded via the fmu-sumo-uploader as one file per realization with content="parameters", and is planned to be added to the new Realization object #774 -> hence there is no longer a need to include it in the object metadata

Adresses #345

@tnatt tnatt self-assigned this Oct 14, 2024
@@ -208,71 +209,28 @@ def uuid_from_string(string: str) -> uuid.UUID:
def read_parameters_txt(pfile: Path | str) -> types.Parameters:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This utility function is used by fmu-sumo-uploader. Can the functionality be moved in there instead @perolavsvendsen ?

Also refactored to simplify the logic and removed the _design_kw file copied from semeio

Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me

@perolavsvendsen
Copy link
Member

I think this should be OK, but I recommend asking around a bit if anyone is actually depending on this before merging. I am pretty sure REP is not using it, but I don't know about Webviz and any other consumer.

@tnatt
Copy link
Collaborator Author

tnatt commented Oct 15, 2024

I think this should be OK, but I recommend asking around a bit if anyone is actually depending on this before merging. I am pretty sure REP is not using it, but I don't know about Webviz and any other consumer.

I have asked a bit around:
DynaGeo does not use ERT parameters per today, and 👍 from Webviz to remove them.
Any other consumers we need to confer before doing the change?

@tnatt tnatt force-pushed the stop_adding_parameters_to_meta branch from b14b956 to 0239b95 Compare October 16, 2024 12:36
@tnatt tnatt force-pushed the stop_adding_parameters_to_meta branch from 0239b95 to 3341ae0 Compare October 16, 2024 12:41
@tnatt tnatt merged commit cfaffbc into equinor:main Oct 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants