Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test that all content enums are represented in AnyData #840

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Oct 8, 2024

This PR addresses #819 and adds a test to check

  • all models in AnyData have a content attribute
  • the annotation of the content attribute is a Literal with one enum.Content value
  • all enums in Content is represented by a pydantic model in AnyData.
  • the number of models in AnyData match the number of enums in Content

relevant problem encountered recently ref #833

This PR is based on #834, which is awaiting #835 to be solved.

Will rebase this one when ☝️ is solved. 😄

@tnatt tnatt self-assigned this Oct 8, 2024
@tnatt tnatt force-pushed the test_all_contents_in_anydata branch 2 times, most recently from 14b0f2f to 323e195 Compare October 9, 2024 06:37
@tnatt tnatt force-pushed the test_all_contents_in_anydata branch from 323e195 to 4607264 Compare October 10, 2024 10:13
@tnatt
Copy link
Collaborator Author

tnatt commented Oct 10, 2024

This is rebased and ready for review now @mferrera 🙂

Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@tnatt tnatt merged commit c53ebac into equinor:main Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants