Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX, DEP: rename from export_rms_volumetrics to export_volumetrics #798

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jcrivenaes
Copy link
Collaborator

@jcrivenaes jcrivenaes commented Sep 24, 2024

Rename name of one-liner function before it comes into production, cf #795

The RMS context is already evident as

from fmu.dataio.export.rms import export_volumetrics

I also added a commit that marks this function as experimental (a bit out of sync, but we do not expect any current users)

@jcrivenaes jcrivenaes force-pushed the rename-rms-volumetrics branch 2 times, most recently from 26fe138 to 5de5422 Compare September 24, 2024 08:30
Copy link
Collaborator

@tnatt tnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@mferrera mferrera mentioned this pull request Sep 26, 2024
4 tasks
@jcrivenaes jcrivenaes merged commit a26bac7 into equinor:main Sep 26, 2024
13 checks passed
@jcrivenaes jcrivenaes deleted the rename-rms-volumetrics branch September 26, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants