-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add num_columns
, num_rows
to table spec
#784
Conversation
path = Path(file_path) | ||
meta_path = path.parent / f".{path.name}.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forget why I type annotated this, and why it's in this PR, but let's call it a freebie
I am worried about retrospective validation. Do these fields need to be optional for backward compatibility? |
This is difficult.. how well is the sumo schema aligned with the komodo version? there is no versioning of the schema atm right? |
I think we just need to tackle versioning sooner rather than later. We have already made far too many changes and called it version 0.8.0. The more changes we implement the higher the risk we cause service interruptions for users. We need to get the fundamentals of deployments right otherwise we are going to build ourselves into a hole we can't get out of. |
Yes. (Missing) schema versioning has been a headache for years. We have discussed linking it to the fmu-dataio version, we have discussed how to migrate between schemas, etc etc. For now, the (not really a) solution has been to make sure we are backwards compatible at all times, and just stay on version However, it needs to be extremely well aligned across So yeah, this is fun topic :) |
Updated these fields to be optional for now. They don't need to be, because the user input isn't required to populate them, but it will maintain backward compatibility. |
b0b8540
to
c90db57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Resolves #768