Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use display_name when explicitly given #402

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Use display_name when explicitly given #402

merged 2 commits into from
Jan 4, 2024

Conversation

perolavsvendsen
Copy link
Member

Solve #319

This PR makes display.name always populated in produced metadata.

  • When display_name argument is given, use it to populate display.name
  • When display_name not given, populate display.name with data.name

jcrivenaes
jcrivenaes approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@perolavsvendsen perolavsvendsen merged commit 975c21c into equinor:main Jan 4, 2024
9 checks passed
@perolavsvendsen perolavsvendsen deleted the 319-display.name branch January 4, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes jcrivenaes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perolavsvendsen @jcrivenaes