-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer selected blocks from global_variables to case metadata #339
base: main
Are you sure you want to change the base?
Transfer selected blocks from global_variables to case metadata #339
Conversation
Note that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the definition of blocks to be in the case metadata seems logical, but isn't it a bit challenging with the contacts and other relevant things, could be volume factors etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this proposal, only one new block in the (case) metadata, which is fmu.case.config
. And then "whatever" into that. I.e. we don't validate in detail, so fmu-dataio can technically include anything into that block.
But given the ongoing discussion around parameters.txt
where we are leaning towards having that as a separate data object, we might discuss this PR in that perspective as well. Should case config be a separate data object? 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, another point - which is possibly what you meant - is access control and information classification. We cannot have a situation where someone is to be granted access to only parts of the case metadata, that would not work.
First stab at partial solving of #337
This PR will transfer selected blocks from
global_variables.yml
into case metadata, when they exist.