Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream media using LiveKit #1745

Merged
merged 14 commits into from
Oct 15, 2024
Merged

Stream media using LiveKit #1745

merged 14 commits into from
Oct 15, 2024

Conversation

sondreo
Copy link
Contributor

@sondreo sondreo commented Sep 20, 2024

No description provided.

@andchiind andchiind mentioned this pull request Sep 20, 2024
Closed
oysand
oysand reviewed Oct 1, 2024
View reviewed changes
frontend/src/App.tsx Outdated Show resolved Hide resolved
oysand
oysand requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@oysand
Copy link
Contributor

oysand commented Oct 4, 2024

Only able to access one video stream at the time. Should be able to open multiple connection in parallel

@oysand
Copy link
Contributor

oysand commented Oct 4, 2024

Full screen view does not resize on window change

@sondreo
Copy link
Contributor Author

sondreo commented Oct 8, 2024 •
edited
Loading

Only able to access one video stream at the time. Should be able to open multiple connection in parallel

Will defer this to a separate issue (#1754) for now.

@sondreo
Copy link
Contributor Author

sondreo commented Oct 8, 2024 •
edited
Loading

Full screen view does not resize on window change

Good catch! Have created a separate improvement issue (#1755).

@sondreo sondreo requested a review from oysand October 9, 2024 07:20
@sondreo sondreo force-pushed the render-videostream branch 4 times, most recently from 110192e to b874ebd Compare October 10, 2024 11:40
oysand
oysand approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@oysand oysand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sondreo sondreo merged commit 4766bbb into equinor:main Oct 15, 2024
10 checks passed
@sondreo sondreo mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind left review comments

@oysand oysand oysand approved these changes

@mrica-equinor mrica-equinor Awaiting requested review from mrica-equinor

Assignees

@andchiind andchiind

@sondreo sondreo

@betaniat betaniat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sondreo @oysand @andchiind @betaniat