Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ES_MDA as recommended algorithm #9771

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ert/gui/simulation/experiment_panel.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ def addExperimentConfigPanel(
experiment_type = panel.get_experiment_type()
self._experiment_widgets[experiment_type] = panel
self._experiment_type_combo.addDescriptionItem(
experiment_type.name(),
experiment_type.name() + experiment_type.name_extranote(),
experiment_type.description(),
experiment_type.group(),
)
Expand Down
4 changes: 4 additions & 0 deletions src/ert/run_models/base_run_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ def log_at_startup(self) -> None:
@abstractmethod
def name(cls) -> str: ...

@classmethod
def name_extranote(cls) -> str:
return ""

@classmethod
@abstractmethod
def description(cls) -> str: ...
Expand Down
2 changes: 1 addition & 1 deletion src/ert/run_models/iterated_ensemble_smoother.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,4 +244,4 @@ def name(cls) -> str:

@classmethod
def description(cls) -> str:
return "Sample parameters → [evaluate → update] several iterations"
return "Sample parameters → [evaluate → update] several iterations.\nDeprecated algorithm. Prefer ES-MDA."
6 changes: 5 additions & 1 deletion src/ert/run_models/multiple_data_assimilation.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,13 @@ def parse_weights(weights: str) -> list[float]:
def name(cls) -> str:
return "Multiple data assimilation"

@classmethod
def name_extranote(cls) -> str:
return " - Recommended algorithm"

@classmethod
def description(cls) -> str:
return "[Sample|restart] → [evaluate → update] for each weight"
return "[Sample|restart] → [evaluate → update] for each weight."

@classmethod
def group(cls) -> str | None:
Expand Down
Loading