Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing realization type in Simulation label #9054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Oct 27, 2024

Issue
Resolves #9053

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:skip If there should be no mention of this in release notes label Oct 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.70%. Comparing base (6153918) to head (bcc731e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9054      +/-   ##
==========================================
+ Coverage   90.67%   90.70%   +0.03%     
==========================================
  Files         349      349              
  Lines       21776    21776              
==========================================
+ Hits        19745    19753       +8     
+ Misses       2031     2023       -8     
Flag Coverage Δ
cli-tests 38.99% <0.00%> (+0.01%) ⬆️
gui-tests 71.70% <100.00%> (+0.02%) ⬆️
performance-tests 49.24% <0.00%> (ø)
unit-tests 79.54% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Running multiple experiments of the same type breaks status view
2 participants