Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return empty df for measureddata w/o responses #9044

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves failing (one but maybe not all) semeio tests

Approach
Handle case of missing responses

@yngve-sk yngve-sk closed this Oct 25, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (64bbc7e) to head (abe2c52).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/data/_measured_data.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9044      +/-   ##
==========================================
- Coverage   90.93%   90.85%   -0.08%     
==========================================
  Files         352      352              
  Lines       21712    21751      +39     
==========================================
+ Hits        19743    19762      +19     
- Misses       1969     1989      +20     
Flag Coverage Δ
cli-tests 39.01% <0.00%> (-0.07%) ⬇️
gui-tests 72.54% <40.00%> (-0.13%) ⬇️
performance-tests 49.46% <0.00%> (-0.09%) ⬇️
unit-tests 79.60% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants