Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport logging fix #9029

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 23, 2024

backport of #9023

@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 23, 2024
@eivindjahren eivindjahren force-pushed the backport_logging_fix branch 2 times, most recently from 6bb5eed to 324ae9a Compare October 23, 2024 12:56
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@eivindjahren eivindjahren enabled auto-merge (rebase) October 23, 2024 12:58
@eivindjahren eivindjahren merged commit cf17517 into equinor:version-11.0 Oct 23, 2024
34 of 35 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.46%. Comparing base (5717e4d) to head (d530e39).
Report is 2 commits behind head on version-11.0.

Files with missing lines Patch % Lines
src/ert/callbacks.py 63.63% 4 Missing ⚠️
src/ert/config/gen_data_config.py 75.00% 4 Missing ⚠️
src/ert/config/_read_summary.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-11.0    #9029      +/-   ##
================================================
- Coverage         91.50%   91.46%   -0.05%     
================================================
  Files               343      343              
  Lines             21276    21293      +17     
================================================
+ Hits              19468    19475       +7     
- Misses             1808     1818      +10     
Flag Coverage Δ
cli-tests 38.95% <35.29%> (-0.03%) ⬇️
gui-tests 72.35% <25.49%> (-0.07%) ⬇️
performance-tests 49.27% <25.49%> (-0.04%) ⬇️
unit-tests 80.11% <80.39%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants