Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid possible UnboundLocalError for end_event #9028

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 23, 2024

Issue
Resolves end_event possibly being unbound

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland enabled auto-merge (rebase) October 23, 2024 12:54
@berland berland disabled auto-merge October 23, 2024 12:54
The error has been observed to occur in the log. Not trying
to display further error messages to why it is None.
@berland berland changed the title Backport end event 11 0 Avoid possible UnboundLocalError for end_event Oct 23, 2024
@berland berland enabled auto-merge (rebase) October 23, 2024 12:56
@berland berland merged commit 0c742c0 into equinor:version-11.0 Oct 23, 2024
34 of 35 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (5717e4d) to head (b04bd19).
Report is 1 commits behind head on version-11.0.

Additional details and impacted files
@@              Coverage Diff              @@
##           version-11.0    #9028   +/-   ##
=============================================
  Coverage         91.50%   91.50%           
=============================================
  Files               343      343           
  Lines             21276    21277    +1     
=============================================
+ Hits              19468    19470    +2     
+ Misses             1808     1807    -1     
Flag Coverage Δ
cli-tests 38.99% <100.00%> (+0.01%) ⬆️
gui-tests 72.42% <100.00%> (+<0.01%) ⬆️
performance-tests 49.30% <100.00%> (-0.02%) ⬇️
unit-tests 80.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants