Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename substitution_list to substitutions #9026

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 23, 2024

Its not a list, and in any case not useful information.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:refactor PR changes code without changing ANY (!) behavior. label Oct 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.96%. Comparing base (ca44e00) to head (7d1c594).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/substitutions.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9026      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.02%     
==========================================
  Files         352      352              
  Lines       21695    21695              
==========================================
- Hits        19739    19735       -4     
- Misses       1956     1960       +4     
Flag Coverage Δ
cli-tests 39.08% <87.87%> (-0.02%) ⬇️
gui-tests 72.73% <90.90%> (+0.02%) ⬆️
performance-tests 49.58% <81.81%> (-0.01%) ⬇️
unit-tests 79.69% <93.93%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👍🏻

@eivindjahren eivindjahren merged commit a867d62 into equinor:main Oct 23, 2024
56 checks passed
@eivindjahren eivindjahren deleted the rename_substition_list branch October 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:refactor PR changes code without changing ANY (!) behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants