Rename job.py to fm_step.py and Job to ForwardModelStep #9022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
force-pushed
the
rename_job_py
branch
from
ec730d9
to
d2092cf
Compare
yngve-sk
reviewed
Oct 23, 2024
| @@ -76,7 +76,7 @@ def killed_by_oom(pids: Sequence[int]) -> bool: | |||
| return False | |||
|
|
|||
|
|
|||
| class Job: | |||
| class FMstep: | |||
There was a problem hiding this comment.
Maybe a nitpick, but I think the S should be big too?
There was a problem hiding this comment.
It probably should. Potentially go all the way and write it as ForwardModelStep? That object name is actually not in use anywhere else in the codebase (although we do use it as a prefix for some other object names)
There was a problem hiding this comment.
ForwardModelStep sounds better to me
berland
force-pushed
the
rename_job_py
branch
from
d2092cf
to
65f58d3
Compare
berland
changed the title
berland
added
the
release-notes:maintenance
yngve-sk
approved these changes
Oct 24, 2024
Plus follow-up in test code and filenames
berland
force-pushed
the
rename_job_py
branch
from
65f58d3
to
d85caf2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9022 +/- ##
==========================================
+ Coverage 90.87% 90.96% +0.09%
==========================================
Files 352 352
Lines 21712 21712
==========================================
+ Hits 19730 19751 +21
+ Misses 1982 1961 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves eye itch
Approach
nvimgit rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable