Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new hook designated for additions to PATH for forward models. #8981

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 17, 2024

Issue
Resolves #8967

Approach

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Oct 17, 2024
@berland berland added the release-notes:improvement Automatically categorise as improvement in release notes label Oct 17, 2024
@berland berland force-pushed the path_as_hook branch 2 times, most recently from f8ed659 to a16990e Compare October 17, 2024 06:39
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (45b9a36) to head (045535d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8981      +/-   ##
==========================================
+ Coverage   91.57%   91.58%   +0.01%     
==========================================
  Files         345      345              
  Lines       21302    21318      +16     
==========================================
+ Hits        19507    19525      +18     
+ Misses       1795     1793       -2     
Flag Coverage Δ
cli-tests 39.71% <29.41%> (-0.01%) ⬇️
gui-tests 73.50% <29.41%> (-0.01%) ⬇️
performance-tests 50.25% <29.41%> (-0.02%) ⬇️
unit-tests 80.34% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to register PATH additions for forward models through plugin system
2 participants