-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ensemble experiment with design matrix #8941
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8941 +/- ##
==========================================
- Coverage 91.00% 90.99% -0.02%
==========================================
Files 349 352 +3
Lines 21645 21718 +73
==========================================
+ Hits 19698 19762 +64
- Misses 1947 1956 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
707fd91
to
88537d3
Compare
403b2fa
to
2fe829a
Compare
b97fc39
to
a2f1053
Compare
2d4c2cf
to
b399e41
Compare
494347a
to
ff892b4
Compare
dbf426b
to
04bf908
Compare
name=self.ensemble_name, | ||
ensemble_size=self.ensemble_size, | ||
) | ||
elif not restart: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should try to make the creation of experiments and ensembles the same for all cases bar restarts. Either by modifying the global parameter_configuration when you use the design matrix or by having a parameters
property in the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restart functionality should also work with design matrix I believe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't put much thought into restart functionality. Will update!
- Prefil active realization box with realizations from design matrix - Use design_matrix parameters in ensemble experiment - add test run cli with design matrix and poly example - add test that save parameters internalize DataFrame parameters in the storage
…ore running experiment
Issue
Resolves #8961
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable