Run ensemble experiment with design matrix #8941
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8941 +/- ##
==========================================
- Coverage 91.00% 90.99% -0.02%
==========================================
Files 349 352 +3
Lines 21645 21718 +73
==========================================
+ Hits 19698 19762 +64
- Misses 1947 1956 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xjules
added
release-notes:new-feature
xjules
force-pushed
the
checkbox_dm
branch
3 times, most recently
from
707fd91
to
88537d3
Compare
xjules
changed the title
xjules
force-pushed
the
checkbox_dm
branch
2 times, most recently
from
403b2fa
to
2fe829a
Compare
xjules
force-pushed
the
checkbox_dm
branch
4 times, most recently
from
b97fc39
to
a2f1053
Compare
jonathan-eq
reviewed
Oct 17, 2024
dafeda
reviewed
Oct 17, 2024
dafeda
reviewed
Oct 17, 2024
xjules
commented
Oct 17, 2024
xjules
force-pushed
the
checkbox_dm
branch
2 times, most recently
from
2d4c2cf
to
b399e41
Compare
dafeda
reviewed
Oct 17, 2024
dafeda
reviewed
Oct 17, 2024
dafeda
reviewed
Oct 17, 2024
xjules
force-pushed
the
checkbox_dm
branch
2 times, most recently
from
494347a
to
ff892b4
Compare
jonathan-eq
reviewed
Oct 18, 2024
xjules
force-pushed
the
checkbox_dm
branch
2 times, most recently
from
dbf426b
to
04bf908
Compare
larsevj
reviewed
Oct 21, 2024
| name=self.ensemble_name, | ||
| ensemble_size=self.ensemble_size, | ||
| ) | ||
| elif not restart: |
There was a problem hiding this comment.
I believe we should try to make the creation of experiments and ensembles the same for all cases bar restarts. Either by modifying the global parameter_configuration when you use the design matrix or by having a parameters property in the class.
There was a problem hiding this comment.
The restart functionality should also work with design matrix I believe.
There was a problem hiding this comment.
Haven't put much thought into restart functionality. Will update!
- Prefil active realization box with realizations from design matrix - Use design_matrix parameters in ensemble experiment - add test run cli with design matrix and poly example - add test that save parameters internalize DataFrame parameters in the storage
…ore running experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8961
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable