-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unit_tests be fast enough for rapid iteration #8690
Conversation
6ba71f0
to
875f571
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8690 +/- ##
==========================================
+ Coverage 90.96% 91.47% +0.50%
==========================================
Files 343 343
Lines 21306 21306
==========================================
+ Hits 19381 19489 +108
+ Misses 1925 1817 -108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5c727be
to
b35ae5b
Compare
d8f9b8c
to
68465a2
Compare
Also adjusted which tests have the integration_tests marker
This removes duplication by merging in coverage generation and doctest into the same workflow
68465a2
to
aaf77b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over this, and this makes sense to do. 👍
This PR separates tests into ui / integration / unit tests, inspired by the testing pyramid. The goal is to apply the definition of unit test that "It can be ran reliably and quickly when small changes are applied". In order to do so, the definition of integration tests becomes "unit tests that didn't quite make it" and kick out cli tests to live along side the more user interaction focused gui tests.
Note, after rearranging, the tests openPBS were unreliable when not separated into their own distgroup. We will have to create an issue for that.
When applicable