Make unit_tests be fast enough for rapid iteration #8690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
testing_pyramid
branch
2 times, most recently
from
6ba71f0
to
875f571
Compare
eivindjahren
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8690 +/- ##
==========================================
+ Coverage 90.96% 91.47% +0.50%
==========================================
Files 343 343
Lines 21306 21306
==========================================
+ Hits 19381 19489 +108
+ Misses 1925 1817 -108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eivindjahren
force-pushed
the
testing_pyramid
branch
12 times, most recently
from
5c727be
to
b35ae5b
Compare
eivindjahren
added
the
release-notes:skip
eivindjahren
force-pushed
the
testing_pyramid
branch
2 times, most recently
from
d8f9b8c
to
68465a2
Compare
Also adjusted which tests have the integration_tests marker
This removes duplication by merging in coverage generation and doctest into the same workflow
eivindjahren
force-pushed
the
testing_pyramid
branch
from
68465a2
to
aaf77b0
Compare
andreas-el
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates tests into ui / integration / unit tests, inspired by the testing pyramid. The goal is to apply the definition of unit test that "It can be ran reliably and quickly when small changes are applied". In order to do so, the definition of integration tests becomes "unit tests that didn't quite make it" and kick out cli tests to live along side the more user interaction focused gui tests.
Note, after rearranging, the tests openPBS were unreliable when not separated into their own distgroup. We will have to create an issue for that.
When applicable