Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve experiment/ensemble name validation in GUI #8646

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Sep 5, 2024

Issue
Resolves #8612

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the improve_validation_experiment_name branch 2 times, most recently from ff4b28e to 2da1b88 Compare September 5, 2024 13:31
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Sep 5, 2024
@larsevj
Copy link
Contributor Author

larsevj commented Sep 5, 2024

Current status:

  • Currently there is no actual validation done for experiment names, you can just ignore the red box and press run
  • In the create experiment dialog the only requirement is that the length of the field must not be 0
  • The target ensemble is not validated in ensemble experiment currently

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (d8b17e4) to head (25b3f42).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8646      +/-   ##
==========================================
+ Coverage   90.90%   90.96%   +0.06%     
==========================================
  Files         343      343              
  Lines       21271    21288      +17     
==========================================
+ Hits        19336    19365      +29     
+ Misses       1935     1923      -12     
Flag Coverage Δ
gui-tests 76.16% <100.00%> (+0.05%) ⬆️
integration-tests 53.35% <21.81%> (-0.07%) ⬇️
unit-tests 68.96% <21.81%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the improve_validation_experiment_name branch 3 times, most recently from 3e40436 to ca1eaff Compare September 11, 2024 11:41
@larsevj
Copy link
Contributor Author

larsevj commented Sep 11, 2024

There are still some remaining issues:

  • Nothing stops you from setting target_ensemble in es_mda restart or manual update in such a way that you get multiple ensembles with the same name. We would then have to validate the substituted '%d', and know how many iterations are to be run.
  • I believe there is still no backend validation in storage for uniqueness of names.

I think this should still work fine if you have already duplicate experiment names in storage, validation only happens when you try to create a new experiment.

Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but think there might be something with restart runs with es-mda? If I run an ensemble experiment, and then switch to the es-mda tab and manually enter: ensemble_experiment as the name, and then check the Restart run checkbox I am not able to start an experiment.

Also feel free to rebase and force push.

@larsevj larsevj force-pushed the improve_validation_experiment_name branch 2 times, most recently from 77445d8 to f6b1ab7 Compare September 13, 2024 09:22
@larsevj larsevj changed the title Improve experiment name validation Improve experiment/ensemble name validation in GUI Sep 13, 2024
@larsevj
Copy link
Contributor Author

larsevj commented Sep 13, 2024

Looks good, but think there might be something with restart runs with es-mda? If I run an ensemble experiment, and then switch to the es-mda tab and manually enter: ensemble_experiment as the name, and then check the Restart run checkbox I am not able to start an experiment.

Should be fixed now.

@larsevj larsevj force-pushed the improve_validation_experiment_name branch from f6b1ab7 to 25b3f42 Compare September 13, 2024 09:25
@larsevj larsevj added release-notes:maintenance Automatically categorise as maintenance change in release notes and removed release-notes:skip If there should be no mention of this in release notes labels Sep 13, 2024
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@larsevj larsevj merged commit dbf2ae6 into equinor:main Sep 16, 2024
35 checks passed
@larsevj larsevj deleted the improve_validation_experiment_name branch September 16, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiment name shown as red with warning when restarting es_mda
3 participants