Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove job_label from run_dialog #8511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Aug 19, 2024

Issue
Resolves #8509

Screenshot 2024-08-19 at 13 11 41

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure tests pass locally (after every commit!)

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI label Aug 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.59%. Comparing base (050498e) to head (ad5c495).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8511      +/-   ##
==========================================
- Coverage   90.61%   90.59%   -0.02%     
==========================================
  Files         342      342              
  Lines       20895    20892       -3     
==========================================
- Hits        18934    18928       -6     
- Misses       1961     1964       +3     
Flag Coverage Δ
gui-tests 75.87% <ø> (+0.03%) ⬆️
integration-tests 54.08% <ø> (+0.03%) ⬆️
unit-tests 68.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:user-impact Automatically categorise as breaking for people using CLI/GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant information on selected realization
3 participants