Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: To Include project id (optional attribute) in Create (Device, DLG, ACL, SSH Public key) and Get details by uuid(Device, DLG, ACL, SSH Public key) #556

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

kpdhulipala
Copy link
Contributor

@kpdhulipala kpdhulipala commented Feb 2, 2024

Reference:https://docs.equinix.com/en-us/Content/IAM/iam-resources-projects.htm

Added changes required to allow customers to send Project ID (optional attribute) in

  1. Create Device and Get Device by uuid
  2. Create ACL Template and Get ACL template by uuid
  3. Create SSH Public Key and Get SSH Public Key by uuid
  4. Create DLG and get DLG details by uuid

Link to PR in ne-go repo
[https://github.com/equinix/ne-go/pull/28]

@kpdhulipala kpdhulipala changed the title Include project id (optional attribute) in Create (Device, DLG, ACL, SSH Public key) and Get details by uuid(Device, DLG, ACL, SSH Public key) feat: To Include project id (optional attribute) in Create (Device, DLG, ACL, SSH Public key) and Get details by uuid(Device, DLG, ACL, SSH Public key) Feb 2, 2024
docs/resources/equinix_network_acl_template.md Outdated Show resolved Hide resolved
equinix/resource_network_device.go Outdated Show resolved Hide resolved
equinix/data_source_network_device.go Outdated Show resolved Hide resolved
equinix/resource_network_device.go Outdated Show resolved Hide resolved
equinix/resource_network_ssh_key.go Outdated Show resolved Hide resolved
@ctreatma
Copy link
Contributor

ctreatma commented Feb 6, 2024

One thing to keep in mind while you're actively working on NE in terraform is that there are a few changes in progress that your team should plan for. The biggest one is that we are introducing support for defining resources/datasource using https://github.com/hashicorp/terraform-plugin-framework/ instead of terraform-plugin-sdk, which Hashicorp has (in practice, if not in documentation) deprecated. SDK-based resources and datasources should continue to work for some time, but as we migrate more and more things to framework it will be important for your team to start thinking about and planning to migrate NE resources and data sources.

@rling-equinix rling-equinix merged commit 2c09c52 into equinix:main Feb 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants