October 2024 revamp #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
5 times, most recently
from
86630a4 to
5048824
Compare
e-minguez
changed the title
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
2 times, most recently
from
c4e45cd to
59a9c9b
Compare
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
from
59a9c9b to
47c0a24
Compare
displague
reviewed
Oct 2, 2024
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
from
47c0a24 to
0b0ac79
Compare
|
What about encoding the initial password in base64? It is just an initial password, you still need to perform the Rancher bootstrap process :) |
displague
reviewed
Oct 3, 2024
displague
previously approved these changes
Oct 3, 2024
There was a problem hiding this comment.
terraform apply of examples/demo_cluster succeeded.
Cluster and demo app ingress was accessible. NodeIP was private.
lgtm
spec:
podCIDR: 10.42.0.0/24
podCIDRs:
- 10.42.0.0/24
providerID: k3s://demo-cluster-cp-aio
status:
addresses:
- address: 10.25.17.3
type: InternalIP
- address: 147.28.227.125
type: ExternalIP
- address: demo-cluster-cp-aio
type: Hostname
|
I want to walk through the RKE deployment and the optional rancher deployment too. I'll give these a try later today. |
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
from
0b0ac79 to
5192b26
Compare
Great! I've just pushed a new version. Now contains a helper script to perform the Rancher bootstrap process automatically as well as importing all the clusters to it. |
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
5 times, most recently
from
e2c81ac to
ce9b45c
Compare
- Replaced Bird by native MetalLB - Setup Ingress IP properly - Deploy an extra Ingress to handle the Global IP (instead of abusing the regular Ingress that makes unable to expose cluster-wide apps and only global ones) - Added Rancher deployment (Rancher flavor and version can be provided) - K3s or RKE2 (any version can be specified) - Added a helper script to perform the Rancher bootstrap process automatically as well as importing all the clusters to it - Added `shfmt` to the pre-commit action - Switched to Terraform >= 1.9.0 (as required to include a new validation) - Fixed pre-commit action -> pre-commit/action#210 Closes equinix-labs#53, closes equinix-labs#81, closes equinix-labs#67, closes equinix-labs#66
e-minguez
force-pushed
the
rancher-rke2-metal3-bird
branch
from
ce9b45c to
3be137a
Compare
dcallao
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
@e-minguez LGTM. I tested your changes and don't see anything outstanding.
displague
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shfmtto the pre-commit actionCloses #53, closes #81, closes #67, closes #66