This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
fix: rename plans query param categories => categories[]
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0mk
changed the title
categories => categories[]
t0mk
force-pushed
the
fix_plans_categories
branch
from
3d46026 to
5e8e150
Compare
t0mk
force-pushed
the
fix_plans_categories
branch
from
0df9ec9 to
434cb21
Compare
t0mk
force-pushed
the
fix_plans_categories
branch
from
434cb21 to
5e8e150
Compare
ctreatma
approved these changes
Jan 11, 2024
|
This hasn't been fixed in |
t0mk
force-pushed
the
fix_plans_categories
branch
from
5e8e150 to
0c73613
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes name of plans listing param
categoriestocategories[].discovered by @ctreatma
#69 (comment)
related to #69
I wonder if we should this also for devices lookup. @ctreatma has this been fixed in metal-go?