Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node sass with sass and #819

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Replace node sass with sass and #819

merged 5 commits into from
Nov 22, 2024

Conversation

pattonwebz
Copy link
Member

This PR replaces node-sass with the sass package and deals with some other deprecations issues and warnings:

  • Replaces inline divisions with calc calls
  • Replaces @import with @use statements
  • Updates webpack and sass-loader to avoid legacy JS warning
  • Tackles a mixed-decl issue with new generation order for styles that appear after other nested rules

Checklist

  • PR is linked to the main issue in the repo
  • Tests are added that cover changes

SteveJonesDev
SteveJonesDev approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@SteveJonesDev SteveJonesDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install is working with these changes.

@pattonwebz pattonwebz merged commit cf1f2e6 into develop Nov 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveJonesDev SteveJonesDev SteveJonesDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pattonwebz @SteveJonesDev