-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added: Fix for adding skip links when they are not there #731
Conversation
Also inlines the styles with it rather than deprecate hook
… not find a target ID to point to
This is being moved to an actual JS file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing all the settings outlined on the card.
380415c
to
330ad16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't fully tested functionality but this looks good to merge in. There is a lot of structure we need in the PR so that we can base off the develop
branch for other fixes.
This PR adds a fix to the plugin that users can add a skip link to their pages with.
#
or not and it will be handled appropriately.<template>
tag added to the page.If you are using a FSE enabled theme like Twenty Twenty-Four then it has some features to add a skip links that lives outside the theme so for testing you will need to remove it and add an ID to target. With Twenty Twenty-Four this code works but you may have to tweak
main
tag to something else if you have a different theme being tested.Checklist