Release/v1.10.1 #552

pattonwebz · 2024-03-26T22:04:13Z

Steve Jones (1):

Missing form label rule strict comparison fix

William Patton (6):

Convert editor meta boxes function into a class
Short-circuit edac_save_post() when post_status is trash
Fix missing clarifying parenthesis cs check
Check we have an array before accessing it when producing density to return via ajax
Handle missing scheme in animated image rule

…er the render

…min class

…o-a-class

…xes-functions-into-a-class Convert editor meta boxes function into a class

…-to-trash-from-block-editor-results-in-error-processing-cleanup Short-circuit edac_save_post() when post_status is trash

Release/v1.10.0

…date the url is existing

…nly instead of duplicated inside other functions

Error flagged is: Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses

… parenthesis added

This reverts commit 30b6f7c.

…clarifying-parenthesis-cs-check Fix missing clarifying parenthesis cs check

…ror_when_image_lacks_scheme

…with expectations

…mplex

The capability is supporting urls that are neither relative not protocol-relative. It's an edge case for sure but no harm in adding support for it.

…tive urls as well Also adds an explicit list of valid schemes as well to support more edge cases

…-can-sometimes-be-a-string-when-it's-expected-to-always-be-an-array Check we have an array before accessing it when producing density to return via ajax

…obust Thanks to the newly added tests for catching my last change here as being a change that had downstream effects :)

…causes_error_when_image_lacks_scheme' into william/544/animage_image_check_causes_error_when_image_lacks_scheme # Conflicts: # includes/helper-functions.php

…e_check_causes_error_when_image_lacks_scheme Handle missing scheme in animated image rule

…g issues #543

…abels-strict-comparison Missing form label rule strict comparison fix

…e changelog

SteveJonesDev

Just need to update the stable tag.

SteveJonesDev · 2024-03-27T17:42:05Z

readme.txt

The stable tag needs to be updated to: 1.10.1

pattonwebz added 30 commits March 15, 2024 22:35

Short-circuit edac_save_post() when post_status is trash

be8416b

Make a new class for the editor metabox

f592a3a

Add an init_hooks to metabox class and add 2 actions before and aft…

952d9af

…er the render

Remove the old meta-boxes functions and flagthem deprecated

0f6eff8

Use Dependency Injection to register the editor metabox inside the Ad…

c95e2be

…min class

Merge branch 'develop' into william/467/make-meta-boxes-functions-int…

481da0b

…o-a-class

Merge pull request #537 from equalizedigital/william/467/make-meta-bo…

9265064

…xes-functions-into-a-class Convert editor meta boxes function into a class

Merge pull request #536 from equalizedigital/william/535/moving-posts…

66bc854

…-to-trash-from-block-editor-results-in-error-processing-cleanup Short-circuit edac_save_post() when post_status is trash

Merge pull request #541 from equalizedigital/release/v1.10.0

a871aa1

Release/v1.10.0

Add asset dir for test with animated and static webp and gif

5f92eed

Add constant to test that points to new asset dir

84be3bd

Add some helpers to try add scheme to file urls missing them and vali…

61e9fc9

…date the url is existing

Add a helper to make opening files as binary live in a single place o…

eaa47ca

…nly instead of duplicated inside other functions

Add tests for the new helper functions

e8a58b9

Swap to new helper to open file as binary and avoid duplicate code

b6f7a9e

Update some comments in the img_animated_gif file

365cb5b

Add some tests that test the full edac_rule_img_animated_gif rule

e8c5ccd

Satisfy missing parenthesis rule CS check introduced in WPCS 3.1.0

aaaf705

Error flagged is: Generic.CodeAnalysis.RequireExplicitBooleanOperatorPrecedence.MissingParentheses

Improve readability of some of the conditions that had new clarifying…

e5539c6

… parenthesis added

Bump wpcs to 3.1 or above

30b6f7c

Revert "Bump wpcs to 3.1 or above"

2a5b3b4

This reverts commit 30b6f7c.

Merge pull request #547 from equalizedigital/william/546/fix-missing-…

3e1055a

…clarifying-parenthesis-cs-check Fix missing clarifying parenthesis cs check

Merge branch 'develop' into william/544/animage_image_check_causes_er…

57bf0f3

…ror_when_image_lacks_scheme

Make sure to check that we are operating on an array before accessing it

959955a

Default value for density_data must be an array, not a string

16e6b41

Make the density calculation sum easier to quickly scan

8a311aa

Add a catch to remap any non-array values to [0,0] for compatibility …

223e040

…with expectations

Remove the just added catch as it's not needed and makes this more co…

ac74b38

…mplex

Add a test to validate the bug is fixed

eaff86b

Add some extra test assertions to cover a new capability that I will add

b6e1573

The capability is supporting urls that are neither relative not protocol-relative. It's an edge case for sure but no harm in adding support for it.

pattonwebz and others added 10 commits March 26, 2024 14:58

Use site scheme as default and support non-relative non-protocol-rela…

7e8da4b

…tive urls as well Also adds an explicit list of valid schemes as well to support more edge cases

Merge pull request #549 from equalizedigital/william/548/density-data…

1179f66

…-can-sometimes-be-a-string-when-it's-expected-to-always-be-an-array Check we have an array before accessing it when producing density to return via ajax

Add a 'rules' group the the ImgAnimatedGifTest.php class

138a847

Restore a checking clause before modifying the url and make it more r…

8c85464

…obust Thanks to the newly added tests for catching my last change here as being a change that had downstream effects :)

Restore a checking clause before modifying the url and make it more r…

98ea77d

…obust Thanks to the newly added tests for catching my last change here as being a change that had downstream effects :)

Merge remote-tracking branch 'origin/william/544/animage_image_check_…

8d09f47

…causes_error_when_image_lacks_scheme' into william/544/animage_image_check_causes_error_when_image_lacks_scheme # Conflicts: # includes/helper-functions.php

Merge pull request #545 from equalizedigital/william/544/animage_imag…

8e16089

…e_check_causes_error_when_image_lacks_scheme Handle missing scheme in animated image rule

fixed - strict comarison preventing misssing form label form returnin…

f8927e4

…g issues #543

Merge pull request #551 from equalizedigital/steve/543/missing-form-l…

4b37736

…abels-strict-comparison Missing form label rule strict comparison fix

Bump version 1.10.0 -> 1.10.1 and add changelog

ff73ab5

pattonwebz changed the title ~~Release v1.10.1~~ Release/v1.10.1 Mar 26, 2024

pattonwebz changed the base branch from develop to main March 26, 2024 22:06

pattonwebz added 2 commits March 26, 2024 22:14

Move something that didn't release in the last version to this releas…

4fd03c2

…e changelog

Update changelog

7abc5b9

pattonwebz requested a review from SteveJonesDev March 26, 2024 22:18

SteveJonesDev requested changes Mar 27, 2024

View reviewed changes

readme.txt

Copy link

Member

SteveJonesDev Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stable tag needs to be updated to: 1.10.1

Update stable tag in readme.txt 1.10.0 -> 1.10.1

37915b9

SteveJonesDev approved these changes Mar 27, 2024

View reviewed changes

pattonwebz merged commit 79d72c3 into main Mar 27, 2024
21 checks passed

pattonwebz deleted the release/1.10.1 branch March 28, 2024 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/v1.10.1 #552

Release/v1.10.1 #552

pattonwebz commented Mar 26, 2024 •

edited by SteveJonesDev

Loading

SteveJonesDev left a comment

SteveJonesDev Mar 27, 2024

Release/v1.10.1 #552

Release/v1.10.1 #552

Conversation

pattonwebz commented Mar 26, 2024 • edited by SteveJonesDev Loading

SteveJonesDev left a comment

Choose a reason for hiding this comment

SteveJonesDev Mar 27, 2024

Choose a reason for hiding this comment

pattonwebz commented Mar 26, 2024 •

edited by SteveJonesDev

Loading