Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing form label rule strict comparison fix #551

Merged

Conversation

SteveJonesDev
Copy link
Member

This PR fixes the strict comparison issue within the missing form label rule that prevented it from returning issues.

Fixes #543

@SteveJonesDev SteveJonesDev self-assigned this Mar 26, 2024
@SteveJonesDev SteveJonesDev added the bug Something isn't working label Mar 26, 2024
Copy link
Member

@pattonwebz pattonwebz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested against one of the demo site posts and see 0 missing label issues before this change and 4 with this change.

@SteveJonesDev SteveJonesDev merged commit 4b37736 into develop Mar 26, 2024
16 checks passed
@SteveJonesDev SteveJonesDev deleted the steve/543/missing-form-labels-strict-comparison branch March 26, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin no longer flagging missing form labels
2 participants