Solve some unexpected situations with frontend highlighter when rules are filtered off #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he rule is now disabled via filter - before returning them
…hat are now disabled via filter
… and enable them only if we have issues to show
SteveJonesDev
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Looks good @pattonwebz! I will update the version and readme file, merge, and release this minor version.
SteveJonesDev
approved these changes
Mar 11, 2024
SteveJonesDev
deleted the
william/hotfix/frontend-highter-handle-filtered-rules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone filters out a certain rule after a page is scanned, the Ajax call still returns those rules to the highlighter in a 'null' state without any information. This PR seeks to not return null data to the highlighter so they are not shown on the frontend when inspecting the page issues.
Widget when loading doesn't show nav buttons anymore
Show buttons only after we know there are issues to display
Show no buttons when no issues were returned from ajax call
Fixes #524