Move edac_insert_rule_data to an inserter class

[pattonwebz]

Moves the edac_insert_rule_data function to a new Insert_Rule_Data class with a single method named insert that takes the same passed params.

• I added type hints on the parameters (should post actually be a \WP_Post type rather than an object?).
• Added an early bail if one of the required params aren't passed (typehints technically prevent this happening but having it makes it more clear what is going on).
• Started adding tests (which still needs more work to cover more of the method).

I have some thoughts about potential refactor of this function so that it can have return values that are likely to give more certainty about what has happened. My initial thought was bool|int and never void. With true being success, false being fail and the int meaning it was a duplicate but would also evaluate to a truth value for checking that might be added later after it's called.

Closes: #464

[SteveJonesDev]

@pattonwebz, are you still working on this PR since it's in draft mode?

[pattonwebz]

@pattonwebz, are you still working on this PR since it's in draft mode?

I still need to work on the tests here for better coverage. If you want to review the actual code changes, that'd be great.

I plan to revisit the tests here tomorrow and the other issues assigned to me.

[SteveJonesDev]

@pattonwebz, should we sanitize this data to ensure it's been filtered in a safe manner?

Example:

// Apply filters to allow modification of the rule data.
$rule_data = apply_filters( 'edac_filter_insert_rule_data', $rule_data );

// Sanitize the filtered data.
$rule_data_sanitized = array(
    'postid'        => absint( $rule_data['postid'] ),
    'siteid'        => absint( $rule_data['siteid'] ),
    'type'          => sanitize_text_field( $rule_data['type'] ),
    'rule'          => sanitize_text_field( $rule_data['rule'] ),
    'ruletype'      => sanitize_text_field( $rule_data['ruletype'] ),
    'object'        => sanitize_text_field( $rule_data['object'] ),
    'recordcheck'   => absint( $rule_data['recordcheck'] ),
    'user'          => absint( $rule_data['user'] ),
    'ignre'         => absint( $rule_data['ignre'] ),
    'ignore_user'   => isset( $rule_data['ignore_user'] ) ? absint( $rule_data['ignore_user'] ) : null,
    'ignore_date'   => isset( $rule_data['ignore_date'] ) ? sanitize_text_field( $rule_data['ignore_date'] ) : null,
    'ignore_comment'=> isset( $rule_data['ignore_comment'] ) ? sanitize_text_field( $rule_data['ignore_comment'] ) : null,
    'ignore_global' => absint( $rule_data['ignore_global'] ),
);

// Now, $rule_data_sanitized contains the sanitized data ready for insertion.

[pattonwebz]

I see that you fixed the ignre to ignore, but we can't do that without first remapping the columns in the table. Would you like me to make an issue to tackle that in the future?

[SteveJonesDev]

Update version to 1.10.0

[SteveJonesDev]

Good to merge.