Hotfix/basic auth fix #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boonedev
commented
Jan 22, 2024
| 'X-WP-Nonce' => wp_create_nonce( 'wp_rest' ), | ||
| 'Authorization' => 'None', | ||
|
|
||
| ); |
There was a problem hiding this comment.
We no longer need to pass auth.
boonedev
commented
Jan 22, 2024
| @@ -77,9 +77,6 @@ function edac_display_welcome_page() { | |||
| */ | |||
| function edac_display_options_page() { | |||
| include_once plugin_dir_path( __DIR__ ) . 'partials/settings-page.php'; | |||
|
|
|||
| // force edac_auth_type to reset in case user updates auth options. | |||
| delete_transient( 'edac_auth_type' ); | |||
| } | |||
boonedev
commented
Jan 22, 2024
| HEADERS = edacpFullSiteScanApp.edacpHeaders; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Removes setting auth headers.
boonedev
commented
Jan 22, 2024
| }); | ||
|
|
||
| } | ||
|
|
boonedev
commented
Jan 22, 2024
| @@ -1,7 +1,5 @@ | |||
| import { settings } from './settings'; | |||
| import { init as initCheckPage } from './checkPage'; | |||
| import { showNotice } from './../common/helpers'; | |||
|
|
|||
SteveJonesDev
requested changes
Jan 23, 2024
There was a problem hiding this comment.
It still requires the password with every page load. Here is a screen recording.
https://www.dropbox.com/scl/fi/jmcq29ioanx0zfn73k6zi/video1714334445.mp4?rlkey=3r1el078cy6hsfk2qzjf9mgyu&dl=0
SteveJonesDev
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: