Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth issue fix #456

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Auth issue fix #456

merged 3 commits into from
Jan 20, 2024

Conversation

boonedev
Copy link
Contributor

@boonedev boonedev commented Jan 19, 2024 •
edited
Loading

This PR fixes https://github.com/equalizedigital/accessibility-checker-pro/issues/186

  • Removes unreliable server side check for determining if site is password protected
  • Removes js-based password protected warnings
  • Fixes PHP Deprecated: Automatic conversion of false to array is deprecated in /var/www/html/wp-content/plugins/accessibility-checker/includes/classes/class-scans-stats.php on line 440

Hotfix
f0a0343 
 - Removes unreliable checks for determining if site is password protected
 - Removes js-based password protected warnings
boonedev
boonedev commented Jan 19, 2024
View reviewed changes
includes/classes/class-helpers.php
}

return false;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not reliable (slow and can fail in loopback).

boonedev
boonedev commented Jan 19, 2024
View reviewed changes
src/editorApp/index.js
}



Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary.

@boonedev boonedev marked this pull request as ready for review January 19, 2024 19:13
matt added 2 commits January 19, 2024 16:03
Bugfix
26f18d9 
 - Fixes: PHP Deprecated:  Automatic conversion of false to array is deprecated in
/var/www/html/wp-content/plugins/accessibility-checker/includes/classes/class-scans-stats.php on line 440
lintfix
e782ad0
@SteveJonesDev SteveJonesDev merged commit 2475396 into release/v1.7.1 Jan 20, 2024
6 checks passed
@SteveJonesDev SteveJonesDev deleted the hotfix/password-fix branch January 20, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveJonesDev SteveJonesDev SteveJonesDev approved these changes

@aristath aristath Awaiting requested review from aristath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boonedev @SteveJonesDev