Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Classic editor conflict #454

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Bugfix: Classic editor conflict #454

merged 1 commit into from
Jan 17, 2024

Conversation

boonedev
Copy link
Contributor

The PR:

  • Exits the listener for editor saves when core/editor is not defined

Before fix:

  • Screenshot 2024-01-12 at 1 36 40 PM
  • Screenshot 2024-01-12 at 1 36 55 PM

After fix:

  • No core/editor related console errors
  • Screenshot 2024-01-12 at 1 37 26 PM

@boonedev boonedev self-assigned this Jan 12, 2024
@boonedev boonedev marked this pull request as ready for review January 12, 2024 19:47
@SteveJonesDev SteveJonesDev merged commit 13fd3c6 into main Jan 17, 2024
7 checks passed
@SteveJonesDev SteveJonesDev deleted the hotfix/classic-editor-conflict branch January 17, 2024 17:34
@SteveJonesDev SteveJonesDev added this to the v1.7.1 milestone Jan 17, 2024
@SteveJonesDev SteveJonesDev mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveJonesDev SteveJonesDev SteveJonesDev approved these changes

@aristath aristath aristath approved these changes

Assignees

@boonedev boonedev

Labels
None yet
Projects
None yet
Milestone
v1.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@boonedev @aristath @SteveJonesDev