Hotfix - basic auth fix #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edacpFullSiteScanApp Adds EDAC\Helpers\is_basic_auth() replaces get_option( 'edac_password_protected') checks with EDAC\Helpers\is_basic_auth() Adds basicAuth to js edac_editor_app Adds auth warning to editor page when user saves a post in free & site requires auth
boonedev
commented
Jan 12, 2024
| edac_check_plugin_active( 'accessibility-checker-pro/accessibility-checker-pro.php' ) | ||
| ) && | ||
| \EDAC\Helpers::is_basic_auth() | ||
| ) { |
There was a problem hiding this comment.
Only show the "Whoops! It looks like your website is currently password protected..." message when editing pages if Pro is not valid/active and we've tested that basic auth is in place.
boonedev
commented
Jan 12, 2024
| let HEADERS; | ||
| if (typeof (edacp_full_site_scan_app) === 'undefined') { | ||
| if (typeof (edacpFullSiteScanApp) === 'undefined') { |
There was a problem hiding this comment.
This misnamed variable is the root cause of the issue b/c the user/pass were not being passed so auth failed.
boonedev
commented
Jan 12, 2024
|
|
||
|
|
||
| checkApi().then((status) => { | ||
|
|
There was a problem hiding this comment.
We're using serverside to test if auth is in place, so no need for this.
boonedev
changed the title
SteveJonesDev
approved these changes
Jan 17, 2024
SteveJonesDev
force-pushed
the
hotfix/basic-auth-fix
branch
from
d033089 to
ef67d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: