Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The edac_log function does not exist #435

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

aristath
Copy link
Collaborator

I noticed a couple of calls to an edac_log function. However, that function does not exist anywhere.
I found edacp_log - and I assume that is the one we wanted to use, so I renamed the calls to the right function.

@aristath aristath added the bug Something isn't working label Dec 20, 2023
Copy link
Member

@SteveJonesDev SteveJonesDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the edac_log function as it was flagging CS issues. I thought I removed all this EDAC_DEBUG logic, but I guess not. We can use edacp_log for now. We could also just use error_log(). I'll merge this for now and we can decide later.

@SteveJonesDev SteveJonesDev merged commit d6adf40 into equalizedigital:develop Dec 20, 2023
11 checks passed
@aristath aristath deleted the fix/edac_log branch December 21, 2023 08:36
@SteveJonesDev SteveJonesDev added this to the v1.8.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants