Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JS linter and fix reported issues #424

Merged
merged 11 commits into from
Dec 15, 2023
Merged

Add JS linter and fix reported issues #424

merged 11 commits into from
Dec 15, 2023

Conversation

aristath
Copy link
Collaborator

@aristath aristath commented Dec 13, 2023 •
edited
Loading

Fixes #370

This PR does the following:

  • Adds a linter for JS
  • Fixes the JS Coding-Standards issues that were reported
  • Adds a GitHub workflow to automatically run the JS Linter on pull-requests

@aristath aristath changed the title 🚧 WIP: Add JS linter and fix reported issues Add JS linter and fix reported issues Dec 14, 2023
@aristath aristath marked this pull request as ready for review December 14, 2023 08:09
@SteveJonesDev SteveJonesDev mentioned this pull request Dec 14, 2023
Closed
@SteveJonesDev SteveJonesDev merged commit d38371b into equalizedigital:develop Dec 15, 2023
11 checks passed
@aristath aristath deleted the fix/js-cs branch December 19, 2023 09:45
@aristath aristath mentioned this pull request Dec 20, 2023
Merged
@SteveJonesDev SteveJonesDev added this to the v1.8.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveJonesDev SteveJonesDev SteveJonesDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

Setup ESLint and GitHub Workflow
2 participants
@aristath @SteveJonesDev