Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting a $plugin_check global variable #420

Merged

Conversation

aristath
Copy link
Collaborator

When adding a variable directly in an included file, it becomes accessible to all of WP.
So this:

$foo = 'bar';

is like this:

global $foo;
$foo = 'bar';

Unless that's what we want to do, we should avoid doing it because it might override some other global variable set by another plugin/theme/WP.

@SteveJonesDev SteveJonesDev merged commit 7a570d9 into equalizedigital:develop Dec 13, 2023
10 checks passed
@SteveJonesDev SteveJonesDev added this to the v1.8.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants