Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/admin notice constructor #395 #417

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

SteveJonesDev
Copy link
Member

@SteveJonesDev SteveJonesDev commented Dec 12, 2023

This PR removes hooks from the constructor of EDAC\Admin_Notices and adds basic unit tests.

  • Added init_hooks method to the EDAC\Admin_Notices class.
  • Moved hooks out of the constructor
  • Created test-admin_notices.php unit test that tests for returned strings and expected messages.

#395

@SteveJonesDev SteveJonesDev merged commit 344f7f9 into develop Dec 13, 2023
15 checks passed
@SteveJonesDev SteveJonesDev deleted the fix/admin-notice-constructor branch December 13, 2023 03:15
@SteveJonesDev SteveJonesDev added this to the v1.8.0 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant