Merge pull request #421 from aristath/fix/global-var/rules

Avoid setting a `$rules` global variable
equalizedigital · Dec 13, 2023 · 72f55f4 · 72f55f4
2 parents 7a570d9 + f00b4e2
commit 72f55f4
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/accessibility-checker.php b/accessibility-checker.php
@@ -239,18 +239,22 @@ function edac_register_rules() {
 /**
  * Include Rules
  *
- * @var object $rules
+ * @return void
  */
-$rules = edac_register_rules();
-if ( $rules ) {
+function edac_include_rules_files() {
+	$rules = edac_register_rules();
+	if ( ! $rules ) {
+		return;
+	}
 	foreach ( $rules as $rule ) {
-		if ( ( array_key_exists( 'ruleset', $rule ) && 'php' === $rule['ruleset'] ) ||
-		( ! array_key_exists( 'ruleset', $rule ) && $rule['slug'] ) ) {
+		if ( ( array_key_exists( 'ruleset', $rule ) && 'php' === $rule['ruleset'] )
+			|| ( ! array_key_exists( 'ruleset', $rule ) && $rule['slug'] ) 
+		) {
 			require_once plugin_dir_path( __FILE__ ) . 'includes/rules/' . $rule['slug'] . '.php';
 		}
 	}
 }
-
+edac_include_rules_files();
 
 /**
  * Code that needs to run before the page is rendered