Detection trim #582
Merged
Detection trim #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As noted in #573 - lag-calc fails to run sometimes when slicing to particular lengths. This happens when the pick.time - pre_pick does not fall on a sample. Obspy will often slice to give a shorter window than needed. This PR now slices starting at the nearest sample before the pick.time - pre_pick to ensure that data are trimmed to within one sample of the requested length.
Why was it initiated? Any relevant Issues?
#573
PR Checklist
developbase branch selected?CHANGES.md.CONTRIBUTORS.md.