Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate daylong #580

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Deprecate daylong #580

merged 2 commits into from
Jul 25, 2024

Conversation

calum-chamberlain
Copy link
Member

What does this PR do?

The daylong argument for processing and associated functions/methods has not been needed for a while now, and doesn't now work as expected (see #573). This PR removes the unneeded argument.

Why was it initiated? Any relevant Issues?

#573

PR Checklist

  • develop base branch selected?
  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGES.md.
  • First time contributors have added your name to CONTRIBUTORS.md.

@calum-chamberlain calum-chamberlain merged commit 3aab7e8 into develop Jul 25, 2024
18 of 20 checks passed
@calum-chamberlain calum-chamberlain mentioned this pull request Jul 25, 2024
Open
@calum-chamberlain calum-chamberlain deleted the deprecate-daylong branch July 25, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calum-chamberlain